Changeset 463

Timestamp:

03/01/09 01:04:38 (9 months ago)

Author:

eevee

Message:

Fixed some uninit warnings, which were flooding Apache's error log.

Location:

veekun/trunk/lib/Vee

Files:

• Controller/Root.pm (modified) (1 diff)
• Form.pm (modified) (1 diff)
• Utils.pm (modified) (2 diffs)

veekun/trunk/lib/Vee/Controller/Root.pm

@@ -264 +264 @@
     my (undef, $details, undef, @log) = <$svn_fh>;
     close $svn_fh;
+    die "Couldn't get svn details" if not defined $details;
+
     my ($rev, $user, $time, undef) = split / \| /, $details;
     $rev =~ s/^r//;

veekun/trunk/lib/Vee/Form.pm

@@ -275 +275 @@
         }
     }
+
+    $attr{value} = '' if not defined $attr{value};
 
     # boring old textbox or passwordbox; nothing special

veekun/trunk/lib/Vee/Utils.pm

@@ -51 +51 @@
 sub postrank {
     my ($post_count) = @_;
+    $post_count ||= 0;
     for my $rank (
         sort { $b <=> $a }
@@ -115 +116 @@
 sub hexcolor { return tohex($_[0]).tohex($_[1]).tohex($_[2]); }
 sub tohex { return sprintf("%02x", $_[0]); }
-sub isnum { return ($_[0] =~ /^ [+-]? \d+ (?:\. [0-9]*)? $/x) }
+sub isnum { return (defined $_[0] and $_[0] =~ /^ [+-]? \d+ (?:\. [0-9]*)? $/x) }
 sub max { my ($i, $max); while (!defined $max) { $max = shift; } for $i (@_) { next unless defined $i; if ($i > $max) { $max = $i } } return $max; }
 sub min { my ($i, $min); while (!defined $min) { $min = shift; }  for $i (@_) { next unless defined $i; if ($i < $min) { $min = $i } } return $min; }