Changeset 440

Timestamp:

05/27/08 02:35:08 (22 months ago)

Author:

eevee

Message:

Fixed uri_for encoding its query args more and more on successive calls with the same hashref containing an arrayref. This is actually a Catalyst "problem", but it seems to have "working as intended" status. (#312)

Files:

• veekun/trunk/lib/Vee.pm (modified) (3 diffs)

veekun/trunk/lib/Vee.pm

@@ -8 +8 @@
 use Image::Size;
 use LWP::UserAgent;
+use Storable qw/dclone/;
 use Time::Out qw/timeout/;
 use YAML qw//;
@@ -139 +140 @@
 sub uri {
     my ($self, $con, $sub, @args) = @_;
+
     my $url = $self->uri_for(
         $self->controller($con)->action_for($sub),
@@ -144 +146 @@
     );
     $url =~ tr/&/;/; # fuck ampersands
+
     return $url;
+}
+
+=head2 uri_for
+
+Override of Catalyst's uri_for that clones parameters before passing them
+along, so I don't have to worry about e.g. reusing the same query args hashref
+several times in a template.
+
+=cut
+
+sub uri_for {
+    my ($self, @etc) = @_;
+
+    # Only the last parameter can be a query arg hashref
+    if (@etc and ref $etc[-1] eq 'HASH') {
+        $etc[-1] = dclone $etc[-1];
+    }
+
+    return $self->next::method(@etc);
 }