Changeset 432 for veekun/trunk/lib/Vee/Controller

Timestamp:

05/23/08 02:41:12 (22 months ago)

Author:

eevee

Message:

Changed breeding chain calculator to interpret its Pokemon input as a target rather than.. whatever it was before. (#309)
Also added some more detail on reading the results.

Files:

• veekun/trunk/lib/Vee/Controller/Dex/Utils.pm (modified) (3 diffs)

veekun/trunk/lib/Vee/Controller/Dex/Utils.pm

@@ -270 +270 @@
     }
 
-    if ($pokemon->breeding_code == 255) {
-        $s->{error_msg} = $pokemon->name . ' cannot breed.';
+    my $basic_form = $pokemon->evo_chain->basic_form;
+    my @egg_forms  = $pokemon->evo_chain->egg_forms;
+
+    warn join "\n", map { $_->name } @egg_forms;
+    # N.B.: this assumes (correctly, as of DP) that every gendered Pokemon in
+    # a given chain has the same breeding code.
+    my $breedable_form = $pokemon->evo_chain->pokemon({
+        'breeds.breed' => { '!=' => 15 },
+    }, {
+        join           => 'breeds',
+    })->first;
+    if (not $breedable_form) {
+        $s->{error_msg} = 'Nothing in the ' . $basic_form->name
+                        . ' family can breed.';
         return;
     }
 
     my @unlearnable_moves;
-    for my $move (@moves) {
-        my $method = $pokemon->move_method_string($move, $version);
-        if (not $method) {
-            push @unlearnable_moves, $move;
-        }
+    MOVE: for my $move (@moves) {
+        for my $egg (@egg_forms) {
+            next MOVE if $egg->move_method_string($move, $version);
+        }
+
+        push @unlearnable_moves, $move;
     }
     if (@unlearnable_moves) {
@@ -287 +300 @@
             $move_names[-1] = 'or ' . $move_names[-1];
         }
-        $s->{error_msg} = $pokemon->name . " cannot inherit "
-                        . join(', ', @move_names) . '.';
+        $s->{error_msg} = 'No egg in the ' . $basic_form->name . ' family can'
+                        . ' inherit ' . join(', ', @move_names) . '.';
         return;
     }
@@ -329 +342 @@
     # tree iteratively from there
     my %egg_groups_tree = (
-        groups   => [ $pokemon->breeding_groups ],
-        pokemon  => [ $pokemon ],
+        groups   => [ $breedable_form->breeding_groups ],
+        pokemon  => [ @egg_forms ],
         children => [],
     );