Changeset 350 for veekun/trunk/lib/Vee/Schema/ThreadViews.pm

Timestamp:

10/23/07 01:30:10 (2 years ago)

Author:

eevee

Message:

I discovered that DBIx::Class::Schema::Loader had been filling my table classes with lines of the form __PACKAGE__->add_unique_constraint(['id'], undef); erroneously, due to someone's inadvertently iterating over %hash rather than keys %hash. Not only were these lines redundant in the case of a primary key, but the parameters are supposed to be a name and a list of columns: thus I had a lot of constraints with ARRAY(0x...) as names and no columns. This was thoroughly breaking $schema->deploy, as it was trying to create indices with garbage names that looked like functions. I have, obviously, removed them all.
In the process, I have done something I've been meaning to do for a while: cleaned up the source in every single file to match my usual style. No auto-gen comment, no redundant loading of PK::Auto, no double-newline after the 1;, proper POD, use of qw// for passing lists, etc. This is actually a teeny part of my db cleanup tracking bug. (#58)

Files:

• veekun/trunk/lib/Vee/Schema/ThreadViews.pm (modified) (2 diffs)

veekun/trunk/lib/Vee/Schema/ThreadViews.pm

@@ -3 +3 @@
 use strict;
 use warnings;
-
 use base 'DBIx::Class';
 
-__PACKAGE__->load_components("PK::Auto", "Core");
-__PACKAGE__->table("thread_views");
+=head1 NAME
+
+Vee::Schema::ThreadViews - DBIC class for the C<thread_views> table
+
+=cut
+
+__PACKAGE__->load_components('Core');
+__PACKAGE__->table('thread_views');
 __PACKAGE__->add_columns(qw/ thread_id user_id last_viewed /);
-__PACKAGE__->set_primary_key('thread_id', 'user_id');
-__PACKAGE__->add_unique_constraint(['thread_id', 'user_id'], undef);
+__PACKAGE__->set_primary_key(qw/ thread_id user_id /);
 
 __PACKAGE__->belongs_to(thread => 'Vee::Schema::Threads', 'thread_id', { join_type => 'LEFT' });
@@ -16 +20 @@
 # TODO: thread and user need to join to me!
 
+=head1 SEE ALSO
+
+L<Vee::Schema>, L<DBIx::Class>
+
+=head1 AUTHOR
+
+Maintainer: Alex "Eevee" Munroe (C<veekun@veekun.com>)
+
+See the included F<AUTHORS> file for a full list of contributers.
+
+=head1 LICENSE
+
+See the included F<LICENSE> file.
+
+=cut
+
 1;
-