Show
Ignore:
Timestamp:
10/23/07 01:30:10 (14 months ago)
Author:
eevee
Message:

I discovered that DBIx::Class::Schema::Loader had been filling my table classes with lines of the form __PACKAGE__->add_unique_constraint(['id'], undef); erroneously, due to someone's inadvertently iterating over %hash rather than keys %hash. Not only were these lines redundant in the case of a primary key, but the parameters are supposed to be a name and a list of columns: thus I had a lot of constraints with ARRAY(0x...) as names and no columns. This was thoroughly breaking $schema->deploy, as it was trying to create indices with garbage names that looked like functions. I have, obviously, removed them all.
In the process, I have done something I've been meaning to do for a while: cleaned up the source in every single file to match my usual style. No auto-gen comment, no redundant loading of PK::Auto, no double-newline after the 1;, proper POD, use of qw// for passing lists, etc. This is actually a teeny part of my db cleanup tracking bug. (#58)

Files:
1 modified

Legend:

Unmodified
Added
Removed

  • veekun/trunk/lib/Vee/Schema/Gallery.pm

    r31 r350  
    11package Vee::Schema::Gallery; 
    2  
    3 # Created by DBIx::Class::Schema::Loader v0.03003 @ 2006-07-11 01:54:10 
    42 
    53use strict; 
    64use warnings; 
    7  
    85use base 'DBIx::Class'; 
    96 
    10 __PACKAGE__->load_components("PK::Auto", "Core"); 
    11 __PACKAGE__->table("gallery"); 
    12 __PACKAGE__->add_columns( 
    13   "id", 
    14   "creatorid", 
    15   "filename", 
    16   "uploaderid", 
    17   "approverid", 
    18   "time", 
    19   "hash", 
    20   "title", 
    21   "description", 
    22   "height", 
    23   "width", 
    24   "seriesid", 
    25   "position", 
    26   "type", 
    27 ); 
    28 __PACKAGE__->set_primary_key("id"); 
    29 __PACKAGE__->add_unique_constraint("filename", ["filename"]); 
    30 __PACKAGE__->add_unique_constraint(["filename"], undef); 
    31 __PACKAGE__->add_unique_constraint(["id"], undef); 
     7=head1 NAME 
     8 
     9Vee::Schema::Gallery - DBIC class for the C<gallery> table 
     10 
     11=cut 
     12 
     13__PACKAGE__->load_components('Core'); 
     14__PACKAGE__->table('gallery'); 
     15__PACKAGE__->add_columns(qw/ 
     16    id 
     17    creatorid 
     18    filename 
     19    uploaderid 
     20    approverid 
     21    time 
     22    hash 
     23    title 
     24    description 
     25    height 
     26    width 
     27    seriesid 
     28    position 
     29    type 
     30/); 
     31__PACKAGE__->set_primary_key('id'); 
     32__PACKAGE__->add_unique_constraint(filename => ['filename']); 
     33 
     34=head1 SEE ALSO 
     35 
     36L<Vee::Schema>, L<DBIx::Class> 
     37 
     38=head1 AUTHOR 
     39 
     40Maintainer: Alex "Eevee" Munroe (C<veekun@veekun.com>) 
     41 
     42See the included F<AUTHORS> file for a full list of contributers. 
     43 
     44=head1 LICENSE 
     45 
     46See the included F<LICENSE> file. 
     47 
     48=cut 
    3249 
    33501; 
    34