Changeset 349

Timestamp:

10/22/07 01:48:24 (14 months ago)

Author:

eevee

Message:

Rewrote some of the test names in the Pokemon search test to focus on what I'm testing, not how I'm testing it.

Location:

veekun/trunk/t

Files:

• dex-search-moves.t (modified) (2 diffs)
• dex-search-pokemon.t (modified) (2 diffs)

veekun/trunk/t/dex-search-moves.t

@@ -27 +27 @@
 search_ok { name => 'fire', class => 'physical' },
     [qw/ 7 221 424 /],
-    "Damage class (with name)";
+    "Damage class (+ name)";
 
 search_ok { class => 'special', type => 'dark' },
     [qw/ 399 /],
-    "Type (with damage class)";
+    "Type (+ damage class)";
 
 search_ok { type => 'dragon', generation => 1 },
     [qw/ 200 225 239/],
-    "Generation (with type)";
+    "Generation (+ type)";
 
 search_ok { type => 'steel', generation => 0 },
@@ -67 +67 @@
 search_ok { name => 'fire', sort => 'name' },
     [qw/ 126 424 7 83 221 /],
-    "Sorting (with name)";
+    "Sorting (+ name)";
 
 # TODO: This is remarkably similar to the Pokemon search sub!  Generalize and

veekun/trunk/t/dex-search-pokemon.t

@@ -28 +28 @@
 search_ok { ability => 'Drizzle' },
     [qw/ 382 /],
-    "Only Kyogre has Drizzle";
+    "Ability";
 
 search_ok { color => 'black', habitat => 'urban' },
     [qw/ 197 353 354 /],
-    "Black urban Pokemon";
+    "Color and habitat";
 
 search_ok { name => 'eon', evo_stage => 'base' },
     [qw/ 352 456 /],
-    "The only baseform *eon*s are Kecleon and Finneon";
+    "Baseforms (+ name)";
 
 search_ok { name => 'char', evo_stage => 'final' },
     [qw/ 6 /],
-    "The only final form *char* is Charizard";
+    "Final forms (+ name)";
 
 # Gender dropdown had a few problems at one point, so I gave it several tests
 search_ok { gender => 254, generation => 0 },
     [qw/ 29 30 31 113 115 124 /],
-    "Female-onlys in RBY";
+    "Female-only (+ generation)";
 
 search_ok { name => 'voltorb', gender => 'not255' },
     [qw/ /],
-    "Voltorb isn't returned by 'any gender'";
+    "Any gender (+ name)";
 
 search_ok { name => 'eevee', gender => 255 },
     [qw/ /],
-    "Eevee isn't returned by 'no gender'";
+    "No gender (+ impossible name)";
 
 # Likewise with the breeding; that's gone wrong several times
 search_ok { breed_mode => 'and', breed => [1, 2], evo_stage => 'base' },
     [qw/ 7 79 131 158 258 /],
-    "Families that are Monster/Water 1";
+    "Two different egg groups with 'and' (+ baseform)";
 
 search_ok { breed_mode => 'and', breed => [13, 13] },
     [qw/ 132 /],
-    "Only Ditto is in the Ditto/Ditto group's'";
+    "Two identical egg groups with 'and'";
 
 search_ok { breed_mode => 'and', breed => [13, 0] },
     [qw/ 132 /],
-    "Ditto is also returned when searching for Ditto and n/a";
+    "One egg group plus n/a with 'and'";
 
 search_ok { breed_mode => 'and', breed => [13, 5] },
     [qw/ /],
-    "...but not when searching for Ditto and any other group";
+    "Two different egg groups with 'and' that can't occur together";
 
 search_ok {
@@ -79 +79 @@
     },
     [qw/ 72 88 90 92 98 109 120 138 140 /],
-    "RBY families that are Water 3 *or* Indeterminate";
+    "Two different egg groups with 'or' (+ generation and baseform)";
 
 search_ok { generation => 2, basedex => 3 },
     [qw/ 265 266 267 268 269 278 279 298 307 308 315 339 340 349 350 358 /],
-    "Pokemon from GSC that appear in DP";
+    "Generation and base Pokedex";
 
 # Types are another common problem area
 search_ok { name => 'eon', type_mode => 'any', type => [qw/ fire /] },
     [qw/ 5 136 /],
-    "Fire *eon*s";
+    "Single type with 'any' (+ name)";
 
 search_ok { name => 'eon', type_mode => 'any', type => [qw/ fire water /] },
     [qw/ 5 134 136 395 456 457 /],
-    "Fire or water *eon*s";
+    "Two types with 'any' (+ name)";
 
 search_ok { name => 'eon', type_mode => 'any', type => [qw/ fire water electric /] },
     [qw/ 5 134 135 136 395 456 457 /],
-    "Fire or water or electric *eon*s";
+    "Three types with 'any' (+ name)";
 
 search_ok { type_mode => 'all', type => [qw/ bug dragon /] },
     [qw/ /],
-    "Bug/dragon Pokemon";
+    "Two types with 'all' that never occur";
 
 search_ok { type_mode => 'all', type => [qw/ ghost dragon /] },
     [qw/ 487 /],
-    "Ghost/dragon Pokemon";
+    "Two types with 'all'";
 
 search_ok { type_mode => 'all', type => [qw/ dragon ghost /] },
     [qw/ 487 /],
-    "Dragon/ghost Pokemon (i.e. order doesn't matter)";
+    "Same two types with 'all', reversed (i.e. order doesn't matter)";
 
 search_ok { type_mode => 'all', type => [qw/ normal flying psychic /] },
     [qw/ /],
-    "Must have three types";
+    "Three types with 'all'";
 
-# Moves have a lot of possibilities; I just try a few here
+# Moves have a lot of possibilities; I just try a few easy ones here
 search_ok { move => 'judgment' },
     [qw/ 493 /],
-    "Learns Judgment";
+    "Single move";
 
 search_ok { move => 'judgment', move_method => [qw/ egg machine tutor /] },
     [qw/ /],
-    "...by leveling up";
+    "Single move not by leveling up";
 
 search_ok { move => 'judgment', move_version => [qw/ rb y gs c rusa frlg e /] },
     [qw/ /],
-    "...not in DP";
+    "Single move by not in D/P";
 
 search_ok { move => [qw/ splash tackle /], move_version => 'rb' },
     [qw/ 129 /],
-    "Learns Splash and Tackle in RB";
+    "Two moves in a specific generation";
 
 # Similar for the stats; these all work the same so whatever
 search_ok { stat_hp_lb => 250 },
     [qw/ 113 242 /],
-    "HP stat of 250+";
+    "Lower bound on HP";
 
 # Height and weight had some rounding issues
 search_ok { generation => 1, height_lb => 16, height_ub => 16 },
     [qw/ 182 183 187 194 220 238 /],
-    "GSC Pokemon that are 16\" tall";
+    "Exact height in inches (+ generation)";
 
 search_ok { height_lb => '0.2m', height_ub => '0.2m' },
     [qw/ 50 177 298 406 412 433 492 /],
-    "Pokemon that are 0.2m tall";
+    "Exact height in meters";
 
 search_ok { height_lb => '20cm', height_ub => '20cm' },
     [qw/ 50 177 298 406 412 433 492 /],
-    "Pokemon that are 20cm tall (same as above)";
+    "Exact height in centimeters";
 
 # Quick sorting checks