Changeset 343

Timestamp:

10/15/07 00:43:35 (2 years ago)

Author:

eevee

Message:

Pokemon search test is now useful and passes. Since the fake context/request turned out to be unnecessary, I have removed them.

Location:

veekun/trunk/t

Files:

• dex-search.t (modified) (1 diff)
• lib (deleted)
• playskool.t (deleted)
• playskool2.t (deleted)

veekun/trunk/t/dex-search.t

@@ -5 +5 @@
 use lib 'lib';
 
-use Test::Simple 'no_plan';
+use Test::More tests => 34;
 
 BEGIN { $ENV{CATALYST_DEBUG} = 0; }
-use Vee;
+BEGIN { use_ok 'Catalyst::Test', 'Vee' }
+BEGIN { use_ok 'Vee::Controller::Dex::Search' }
 
-my @results = do_search( name => 'eon' );
-use Data::Dumper; $Data::Dumper::Maxdepth = 3; warn Dumper(\@results);
-warn $results[0]->name;
-warn $results[0]->has_column_loaded('name');
+sub search_ok;
 
-ok 1;
+### Simple search tests; these get slightly more complex as they go on, and in
+### general I tried to keep the resultset small so it's easy to verify manually
 
+ok request('/dex/pokemon/search')->is_success, "Pokemon search page loads";
 
+search_ok { name => 'eon' },
+    [qw/ 5 134 135 136 196 197 352 395 456 457 470 471 /],
+    "Name substring";
 
-sub do_search {
-    my %params = @_;
+search_ok { ability => 'Drizzle' },
+    [qw/ 382 /],
+    "Only Kyogre has Drizzle";
+
+search_ok { color => 'black', habitat => 'urban' },
+    [qw/ 197 353 354 /],
+    "Black urban Pokemon";
+
+search_ok { name => 'eon', evo_stage => 'base' },
+    [qw/ 352 456 /],
+    "The only baseform *eon*s are Kecleon and Finneon";
+
+search_ok { name => 'char', evo_stage => 'final' },
+    [qw/ 6 /],
+    "The only final form *char* is Charizard";
+
+# Gender dropdown had a few problems at one point, so I gave it several tests
+search_ok { gender => 254, generation => 0 },
+    [qw/ 29 30 31 113 115 124 /],
+    "Female-onlys in RBY";
+
+search_ok { name => 'voltorb', gender => 'not255' },
+    [qw/ /],
+    "Voltorb isn't returned by 'any gender'";
+
+search_ok { name => 'eevee', gender => 255 },
+    [qw/ /],
+    "Eevee isn't returned by 'no gender'";
+
+# Likewise with the breeding; that's gone wrong several times
+search_ok { breed_mode => 'and', breed => [1, 2], evo_stage => 'base' },
+    [qw/ 7 79 131 158 258 /],
+    "Families that are Monster/Water 1";
+
+search_ok { breed_mode => 'and', breed => [13, 13] },
+    [qw/ 132 /],
+    "Only Ditto is in the Ditto/Ditto group's'";
+
+search_ok { breed_mode => 'and', breed => [13, 0] },
+    [qw/ 132 /],
+    "Ditto is also returned when searching for Ditto and n/a";
+
+search_ok { breed_mode => 'and', breed => [13, 5] },
+    [qw/ /],
+    "...but not when searching for Ditto and any other group";
+
+search_ok {
+        breed_mode => 'or',
+        breed      => [9, 11],
+        evo_stage  => 'base',
+        generation => 0,
+    },
+    [qw/ 72 88 90 92 98 109 120 138 140 /],
+    "RBY families that are Water 3 *or* Indeterminate";
+
+search_ok { generation => 2, basedex => 3 },
+    [qw/ 265 266 267 268 269 278 279 298 307 308 315 339 340 349 350 358 /],
+    "Pokemon from GSC that appear in DP";
+
+# Types are another common problem area
+search_ok { name => 'eon', type_mode => 'any', type => [qw/ fire /] },
+    [qw/ 5 136 /],
+    "Fire *eon*s";
+
+search_ok { name => 'eon', type_mode => 'any', type => [qw/ fire water /] },
+    [qw/ 5 134 136 395 456 457 /],
+    "Fire or water *eon*s";
+
+search_ok { name => 'eon', type_mode => 'any', type => [qw/ fire water electric /] },
+    [qw/ 5 134 135 136 395 456 457 /],
+    "Fire or water or electric *eon*s";
+
+search_ok { type_mode => 'all', type => [qw/ bug dragon /] },
+    [qw/ /],
+    "Bug/dragon Pokemon";
+
+search_ok { type_mode => 'all', type => [qw/ ghost dragon /] },
+    [qw/ 487 /],
+    "Ghost/dragon Pokemon";
+
+search_ok { type_mode => 'all', type => [qw/ dragon ghost /] },
+    [qw/ 487 /],
+    "Dragon/ghost Pokemon (i.e. order doesn't matter)";
+
+search_ok { type_mode => 'all', type => [qw/ normal flying psychic /] },
+    [qw/ /],
+    "Must have three types";
+
+# Moves have a lot of possibilities; I just try a few here
+search_ok { move => 'judgment' },
+    [qw/ 493 /],
+    "Learns Judgment";
+
+search_ok { move => 'judgment', move_method => [qw/ egg machine tutor /] },
+    [qw/ /],
+    "...by leveling up";
+
+search_ok { move => 'judgment', move_version => [qw/ rb y gs c rusa frlg e /] },
+    [qw/ /],
+    "...not in DP";
+
+search_ok { move => [qw/ splash tackle /], move_version => 'rb' },
+    [qw/ 129 /],
+    "Learns Splash and Tackle in RB";
+
+# Similar for the stats; these all work the same so whatever
+search_ok { stat_hp_lb => 250 },
+    [qw/ 113 242 /],
+    "HP stat of 250+";
+
+# Height and weight had some rounding issues
+search_ok { generation => 1, height_lb => 16, height_ub => 16 },
+    [qw/ 182 183 187 194 220 238 /],
+    "GSC Pokemon that are 16\" tall";
+
+search_ok { height_lb => '0.2m', height_ub => '0.2m' },
+    [qw/ 50 177 298 406 412 433 492 /],
+    "Pokemon that are 0.2m tall";
+
+search_ok { height_lb => '20cm', height_ub => '20cm' },
+    [qw/ 50 177 298 406 412 433 492 /],
+    "Pokemon that are 20cm tall (same as above)";
+
+# Quick sorting checks
+search_ok { name => 'q', sort => 'stat_avg' },
+    [qw/ 155 7 156 284 195 211 416 31 384 /],
+    "Sorting by average stat";
+
+search_ok { name => 'q', sort => 'id', sort_desc => 'on' },
+    [qw/ 416 384 284 211 195 156 155 31 7 /],
+    "Reverse sort by id";
+
+sub search_ok {
+    my ($params, $expected, $test_name) = @_;
+
+    if (not $params->{sort}) {
+        # sort by id for simplicity
+        $params->{sort} = 'id';
+        delete $params->{sort_desc};
+    }
+
     my $context = Vee->prepare;
-    for my $key (keys %params) {
-        $context->req->params->{$key} = $params{$key};
-    }
+    $context->req->params($params);
     Vee::Controller::Dex::Search->pokemon_search($context);
-    return @{ $context->stash->{results} || [] };
+
+    my $pokemon_rows = $context->stash->{results} || [];
+    my @pokemon = map { $_->id } @$pokemon_rows;
+
+    is_deeply \@pokemon, $expected, $test_name;
 }