Changeset 21

Timestamp:

02/23/07 23:27:09 (3 years ago)

Author:

eevee

Message:

Added last repository message to the top of the index page.
In doing so, also added use of DateTime?, created a once-per-site-instance cache, fixed a doublebug with recent user printing, and fixed the nohtml filter.

Location:

veekun

Files:

• README.pod (modified) (1 diff)
• lib/Vee.pm (modified) (1 diff)
• lib/Vee/Controller/Index.pm (modified) (2 diffs)
• lib/Vee/View/TT.pm (modified) (1 diff)
• site_options.yml (modified) (1 diff)
• templates/index.tt (modified) (2 diffs)

veekun/README.pod

@@ -25 +25 @@
     Catalyst::Plugin::Session::Store::DBIC
     DBIx::Class
+    DateTime
     Email::Valid
     Image::Size

veekun/lib/Vee.pm

@@ -67 +67 @@
 }
 
+=head2 cache
+
+Returns a cache hash for holding small bits of data useful between requests
+but not worth a database table/row/hit.
+
+=cut
+
+my $cache = {};
+sub cache {
+    return $cache;
+}
+
 =head2 uri
 

veekun/lib/Vee/Controller/Index.pm

@@ -4 +4 @@
 use warnings;
 use base 'Catalyst::Controller';
+
+use DateTime;
 
 __PACKAGE__->config->{namespace} = '';
@@ -54 +56 @@
     } );
 
+    # check for latest subversion revision every 15 minutes or so
+    if (not $c->cache->{svn} or $c->cache->{svn}{last_checked} < time - 15 * 60) {
+        eval {
+            open my $svn_fh, '-|', 'svn', 'log', '--limit' => 1, '--incremental', $c->site_opts->{svn_url};
+            my (undef, $details, undef, @log) = <$svn_fh>;
+            close $svn_fh;
+            my ($rev, $user, $time, undef) = split / \| /, $details;
+            $rev =~ s/^r//;
+            my ($yr, $mo, $day, $hr, $min, $sec, $tz) = split /[- :]/, $time, 7;
+
+            $c->cache->{svn} = {
+                revision     => $rev,
+                user         => $user,
+                time         => new DateTime(
+                    year   => $yr,
+                    month  => $mo,
+                    day    => $day,
+                    hour   => $hr,
+                    minute => $min,
+                    second => $sec,
+                    time_zone => substr $tz, 0, 5,
+                ),
+                last_checked => time,
+                log          => join '', @log,
+            }
+        };
+    }
+
+    $s->{recent_revision} = $c->cache->{svn};
+
     $s->{recent_users} = $c->model('DBIC::Users')->search(
         { lastactive => { '>', time - $c->site_opts->{user_activity_timeout} } },

veekun/lib/Vee/View/TT.pm

@@ -45 +45 @@
     FILTERS => {
     #                vee_basic       => \&Vee::format_basic,
-        nohtml      => sub { return Vee->vee_cleanse(@_) },
+        nohtml      => \&Vee::Utils::cleanse,
         bbcode      => \&Vee::BBCode::apply_bbcode,
         timespan    => \&_format_timespan,

veekun/site_options.yml

@@ -70 +70 @@
 user_activity_timeout: 900
 
+# URL for Subversion repository path to check for activity
+# Note that at the moment this *requires* anon access!
+svn_url: svn://veekun.com/veekun
+
 # Number of posts => rank you get
 post_ranks:

veekun/templates/index.tt

@@ -22 +22 @@
 <p>I am wide open to suggestions, comments, criticisms, improvements, and free
 money.</p>
+[% IF recent_revision %]
+<div style="border: 1px dotted navy; -moz-border-radius: 8px; padding: 4px;">
+  <p> <em>Last Subversion commit:</em> <a href="/viewvc?view=rev&amp;revision=[% recent_revision.revision.replace('r','') %]">[% recent_revision.revision %]</a> </p>
+  <p><code>[% recent_revision.log | nohtml %]</code></p>
+  <p>by [% recent_revision.user %] on [% recent_revision.time %]</p>
+</div>
+[% END %]
  <div id="rightcol">
   <div class="front-box">
@@ -44 +51 @@
 [% now = time %]
 [% WHILE (u = recent_users.next) %]
-[%# TODO: what the hell is this, it doesn't work at all does it? %]
-[%     IF !loop.first && loop.last.lastactive > now - 600 && loop.prev.lastactive < now - 600 %] | [% END %]
+[%#     IF NOT done_user_sep AND last_user AND last_user.lastactive < now - 600; done_user_set = 1 %] | [%# END %]
 <a href="/users/[% u.id %]" title="[% now - u.lastactive | timespan %]">[% u.name %]</a>
+[%     last_user = u %]
 [% END %]
 [% IF !recent_users.size %]